Description
Changes proposed in this Pull Request
This PR addresses the design review issues pointed out in pcYYhz-pX-p2#comment-388, pcYYhz-pX-p2#comment-389 and pcYYhz-pX-p2#comment-390, which were:
- “Get your domain” card appearing above the domain filters dropdown
- When clicking the “All my domains” option in the domain filters dropdown, the user was sent to the “All domains” page with the “All domains” filter selected instead of the “Owned by me” filter
- Switch the position of the “+” sign in the “Create site +” and “Add +” (email) links in the domains list
You can compare them with the previous designs:
Testing instructions
- Build this branch locally or open the live Calypso link
- If you’re in the live Calypso link, please append
?flags=domains/management-list-redesign
to your URL to enable the appropriate feature flag
Points to verify:
- “Get your domain” card position
- Select a site with a plan where you haven’t used domain credits yet, i.e. you didn’t claim your free domain
- Go to “Upgrades > Domains”
- Check if the “Get your domain” card appears in the correct location in mobile view
- Clicking “All my domains” filter option
- In the domains filter dropdown, select “All my domains” and ensure you’re taken to the “All domains” page with the “Owned by me” filter selected
- “+ Create site” and “+ Add” links
- In the “All domains” page, ensure that the “Create site +” link reads “+ Create site” now – this link appears for domain-only sites
- Select a site where you have domains without email configured, go to “Upgrades > Domains” and ensure the “Add +” link in the “Email” column reads “+ Add” now
Unfortunately, no screenshots were provided by the developer.