Related to Automattic/dotcom-forge#2261, Automattic/dotcom-forge#2260
Proposed Changes
- Split the default style variation from the Premium style variations in theme showcase and design picker
Testing Instructions
- Use the live link from the comments
- Go to
site-setup/designSetup?siteSlug=your-site (where the your-site is free)
- Click on a free theme and notice that style variations UI is split in two
- Resize your browser resolution to mobile and make sure that the UI looks good.
- Click on a Premium and Woo theme and notice that the UI is not split in two
- Repeat the same step with a site with a premium subscription and notice that all free, premium and Woo themes have the style variations combined in a single list.
- Go to /themes (logged in and logged out)
- Make sure that for free sites, the UI is split in two for free themes
- Make sure that for free sites, the Ui is combined in a single list for Premium and Woo themes
- Make sure that for Premium sites the UI is combined for Free, Premium and Woo themes
- Make sure that the UI looks good on both mobile and desktop resolutions
Screenshots
Theme showcase
Free site, free theme
Premium site, free theme
Free site, free theme (mobile)
Design Picker
Free site, free theme
Free site, free theme (mobile)
Pre-merge Checklist
- Has the general commit checklist been followed? (PCYsg-hS-p2)
- Have you written new tests for your changes?
- Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
- Have you checked for TypeScript, React or other console errors?
- Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
- Have we added the “[Status] String Freeze” label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For changes affecting Jetpack: Have we added the “[Status] Needs Privacy Updates” label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?
Unfortunately, no screenshots were provided by the developer.
