Proposed Changes
PR inspired by this feedback. Not part of the original project brief so see what @zaguiini thinks before merging.
Shows a success <GlobalNotice> after accepting the SALP opt-in banner
Screen.Recording.2022-11-30.at.5.28.31.PM.mov
I did a little searching, and there doesn’t seem to be any consistency around whether global notices should end with a full stop or exclamation point or end with the word “successful”. I went with "Default page updated".
I don’t think we should show anything after rejecting the banner. IMO it doesn’t make sense because, as far as the user is concerned, they haven’t changed any preference. They’re sticking with the status quo.
Testing Instructions
- Delete the entire
sites-landing-page preference object using the dev menu in the bottom right
- Go to
/sites
- Accept banner. After saving is complete the global notice appears. The
calypso_sites_dashboard_landing_page_banner_accept_click banner fires just like it used to.
Unfortunately, no screenshots were provided by the developer.
