Changes proposed in this Pull Request
This PR introduces Domain Picker Modal which is enabled via the gutenboarding/domain-picker-modal
feature flag.
There are some architectural decisions being made here so feel free to review & discuss them in this PR.
The component tree looks like this:
DomainPickerButton
|_DomainPickerPopover
|_DomainPicker
|_DomainPickerModal
|_DomainPicker
Here are the list of changes:
Other changes:
- onClose event removed from CloseButton component
onClose is basically the same as onClick. It was removed to prevent typing issues as onClose
did not accept undefined values. This component is only used by DomainPicker component so far.
Testing instructions
Note: You need to test this locally. Can’t access the modal via the live test page as this is hiding behind a feature flag.
- Go to
/new
and enter your site name.
- Click on domain picker button.
- Domain picker popover should appear.
- Due to refactoring, please test all functionalities of domain picker inside a popover, it should behave like before.
- You should now be able to cycle-tab all the form elements in the domain picker popover, including the close button.
- Click on the More Options button
- Domain picker modal should appear.
- Domain picker button should disappear.
- Resize the browser viewport height until a scrollbar appears.
- Try scrolling the modal content.
- Try opening the domain picker modal on every other gutenboarding pages.
Screenshot
Fixes #41081
Unfortunately, no screenshots were provided by the developer.