Translate 0 originals (0 words) to Icelandic Glossary
Prio | Original string | Translation | — |
---|
Legend:
Current
Waiting
Fuzzy
Old
With warnings
Export strings as
Description
Changes proposed in this Pull Request
- This PR implements a new
GoogleSaleBanner
component that is intended for display in the domains listing page, but the banner should only be displayed when a number of conditions are all met:- The user’s device is larger than a standard mobile device
- We need to be running a sale for Google Workspace via a sale coupon
- The user needs to be in a country that is supported by Google
- The user needs to have at least one domain that doesn’t have paid email service and that domain supports Google Workspace purchases (the most common requirement here is that the domain must use our nameservers)
- If all of the above conditions are met and we have loaded the domain list, we show the banner on the domains listing page
- When the banner is displayed, we log a
calypso_email_google_workspace_sale_banner_impression
event to Tracks with acta_name
prop ofget-google-workspace
. (This implies we should not log this event for mobile devices.) - When the user clicks on the banner, we log a
calypso_email_google_workspace_sale_banner_cta_click
event to Tracks. - This PR also implements some new TS types for the domains package, with the most interesting being the
ResponseDomain
type, which I mostly defined using the code fromclient/state/sites/domains/assembler.js
, which intentionally casts most of the values to specific types.- This piece can be split out into a separate PR if need be, but I think it will be well worth having these types available for documenting domain-related functions using the JSDoc import syntax for types — we don’t need to do this immediately, but we can start making updates as we touch files in various places
- Note that I’ve implemented the banner in both the existing domain listing page and the new UI that’s currently protected by the
domains/management-list-redesign
feature flag. - This PR also addresses what looks like a bug in the underlying
Banner
component for situations where we’re on mobile and the user has specifieddisableCircle
andiconPath
– the icon component is duplicated. I’ll tackle that underlying bug in a follow-up PR.
@Automattic/nomado, @poligilad-auto, and @saygunnyc, please share any feedback that you have on the banner.
Screenshots
Note: the following screenshots were from testing with different discounts — the discount is specified by the coupon configuration.
Desktop
Tablet
Mobile
_As noted here, we’re not going to show the banner on mobile.
New design
Testing instructions
- Getting set up to test this requires access to a back end sandbox, as we need to tackle a few things:
- You need to create a sales coupon for the test Store environment – see D69393-code for instructions
- You need to enable the test Store environment
- You need to modify one of the back end APIs to mock a test domain having WordPress.com nameservers – I have a sample in D69406-code
- Once you have all of those set up, load the UI via a local branch or the live branch
- Go to Upgrades -> Domains for a site that has at least one eligible domain – verify that you see the banner displayed with an eligible domain.
- Verify that the
calypso_email_google_workspace_sale_banner_impression
Tracks event is logged - Load the domains listing page with
?flags=domains/management-list-redesign
and?flags=-domains/management-list-redesign
set in the URL – this will load the new and old components, respectively. - Click on “Get Google Workspace”.
- Verify that a
calypso_email_google_workspace_sale_banner_cta_click
event is logged to Tracks, and you see the email comparison page, and that thesource
URL parameter has a value ofgoogle-sale
.
- For now, this page doesn’t promote/auto-expand Google Workspace during sales – we will tackle that in a follow-up PR
- Also note that #57516 addresses the details we display when Google Workspace is on sale
- Try the steps above for a site that doesn’t have any domains eligible for the purchase – verify that you don’t see the banner.
- Switch your back end APIs to the production API and ensure that you’ve disabled the Store sandbox/test mode.
- Work through the flow again and verify that you don’t see the banner for the sites with and without eligible domains.
Related to #57516
Unfortunately, no screenshots were provided by the developer.